Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API cleanup #10

Merged
merged 11 commits into from Mar 11, 2019

Conversation

Projects
None yet
1 participant
@seanmiddleditch
Copy link
Owner

seanmiddleditch commented Mar 10, 2019

Rename format to format_to

Add format_as though format_string also remains, for now.

Rename and restructure writers:

  • span_writer writes into a provided storage buffer
  • append_writer just calls .append(data, length) on a provided container, for std::string-like containers
  • container_writer calls .insert(.end(), begin, end) on a provided container, for general sequence containers

seanmiddleditch added some commits Mar 9, 2019

Move _detail/append_writer.h definition out of formatxx::_detail
There are complications with getting the type selected imported into
the real namespace. Using declarations don't work (tested in MSVC)
and inherited constructors also don't work (as run into in GCC/Clang).

Looking forward to C++ Modules to be able to solve this correctly
once and for all. :|

@seanmiddleditch seanmiddleditch merged commit 0a6c82e into master Mar 11, 2019

1 check passed

formatxx-CI #545 succeeded
Details

@seanmiddleditch seanmiddleditch deleted the api-cleanup branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.