Skip to content

/reqwest

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide trait impls that are inaccessible to users #106

Closed
dtolnay opened this Issue May 31, 2017 · 1 comment

Comments

Assignees
No one assigned
Labels
easy
Projects
None yet
Milestone
  1.0
2 participants
@dtolnay @seanmonstar
@dtolnay
Copy link

dtolnay commented May 31, 2017 •
edited

The rustdoc for reqwest::Error contains these two distracting impls:

impl From<InternalFrom<Error>> for Error;

impl<T> From<InternalFrom<T>> for Error where T: Into<Kind>;

These are not possible for a user to call. They should be hidden from rustdoc by using #[doc(hidden)].

@dtolnay dtolnay referenced this issue May 31, 2017

Open

In rustdoc, omit trait impls that a user cannot call #42323

@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Author

dtolnay commented May 31, 2017

I filed rust-lang/rust#42323 to follow up on the rustdoc side as well.

@dtolnay dtolnay referenced this issue May 31, 2017

Open

Tracking issue for libz blitz evaluation of reqwest #120

16 of 18 tasks complete

@seanmonstar seanmonstar added the easy label May 31, 2017

@seanmonstar seanmonstar modified the milestone: 1.0 May 31, 2017

@tomprince tomprince referenced this issue Jun 1, 2017

Merged

Hide internal conversions to `reqwest::Error`. #131

@seanmonstar seanmonstar closed this in #131 Jun 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.