Skip to content

/reqwest

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should try_! be exported? #96

Closed
KodrAus opened this Issue May 18, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@KodrAus @seanmonstar
@KodrAus
Copy link
Contributor

KodrAus commented May 18, 2017 •
edited

Hi there!

Just wondering if the try_! macro is meant to exported publicly? Right now it's forming part of the public API, but I'm not sure if it's something consumers are meant to use.
@seanmonstar

This comment has been minimized.

Sign in to view
Copy link
Owner

seanmonstar commented May 18, 2017

Sigh, it's not. It's not possible for someone to use it, since it uses private types internally.

I was hoping to export the macro from the module, so other modules could use it, but I misunderstood how exporting works. Fixed on master, will be published soon.
@KodrAus

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

KodrAus commented May 18, 2017

No worries. I've made the same mistake so many times :(

@KodrAus KodrAus closed this May 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.