Skip to content

/reqwest

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move try_ macro to error.rs. #127

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@seanmonstar seanmonstar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@theduke @seanmonstar
@theduke
Copy link
Contributor

theduke commented May 31, 2017

Fixes #109.
@theduke
Move try_ macro to error.rs. 
Fixes #109.
Loading status checks…
8d01552
@seanmonstar

seanmonstar reviewed May 31, 2017
View changes

src/error.rs
@@ -169,6 +169,26 @@ where T: Into<Kind> {
InternalFrom(err, None).into()
}

#[macro_export]

This comment has been minimized.

Sign in to view
Copy link
@seanmonstar

seanmonstar May 31, 2017

Owner

The #[macro_export] was the original problem here, this actually exports the macro out of the crate. Does this not work without this attribute?
@seanmonstar

This comment has been minimized.

Sign in to view
Copy link
Owner

seanmonstar commented Jun 8, 2017

Thanks for this! I've merged manually, address my one comment, with 583fceb.

@seanmonstar seanmonstar closed this Jun 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.