Skip to content

/reqwest

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use realistic error handling in example code #135

Merged
merged 1 commit into from Jun 2, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alisha17 @seanmonstar
@alisha17
Copy link
Contributor

alisha17 commented Jun 2, 2017

Replace unwrap with '?' according to API guidelines in the example code in lib.rs

Fix to issue #110
@seanmonstar

This comment has been minimized.

Sign in to view
Copy link
Owner

seanmonstar commented Jun 2, 2017

Hi again Alisha!

To get the example working with ?, some other changes are required. Since ? will try to return Err(err), the example needs to be in a function that have a return type of Result. Take a look at the next example in that file to see what I mean.
@alisha17
? instead of unwrap in example
Loading status checks…
31da9da

@alisha17 alisha17 force-pushed the alisha17:error_handling branch from 47d2189 to 31da9da Jun 2, 2017

@seanmonstar seanmonstar merged commit e8eb341 into seanmonstar:master Jun 2, 2017
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@seanmonstar

This comment has been minimized.

Sign in to view
Copy link
Owner

seanmonstar commented Jun 2, 2017

Thanks!

@seanmonstar seanmonstar referenced this pull request Jun 2, 2017

Closed

Use realistic error handling in example code #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.