Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use executor::enter before blocking a thread in wait #538

Merged
merged 1 commit into from Jun 5, 2019

Conversation

@seanmonstar
Copy link
Owner

seanmonstar commented Jun 5, 2019

This should help catch when people use the blocking Client inside some other Future.

@seanmonstar seanmonstar merged commit 5096e12 into master Jun 5, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@seanmonstar seanmonstar deleted the wait-enter branch Jun 5, 2019
FauxFaux added a commit to FauxFaux/unsnap that referenced this pull request Sep 2, 2019
FauxFaux added a commit to FauxFaux/unsnap that referenced this pull request Sep 2, 2019
After reqwest broke everything, seanmonstar/reqwest#538 ,
it's easier to just drop them, and switch to a reasonable http client
which doesn't try and do anything insane inside, breaking everyone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.