Sean McArthur
seanmonstar

Organizations

@mozilla @hyperium
Aug 29, 2016
@seanmonstar

I love it. Seeing all the rules as a list would be far easier to understand what is happening, as well as adding a new one in the thick of things. W…

Aug 28, 2016
seanmonstar commented on pull request hyperium/hyper#899
@seanmonstar

travis logs say the code examples in the guide are now failing.

Aug 28, 2016
@seanmonstar
Aug 28, 2016
seanmonstar merged pull request hyperium/hyper#906
@seanmonstar
refactor(version): bump version of num_cpus to 1.0
1 commit with 1 addition and 1 deletion
Aug 28, 2016
@seanmonstar
Aug 28, 2016
seanmonstar merged pull request hyperium/hyper#905
@seanmonstar
refactor(version): bump version of num_cpus to 1.0
1 commit with 1 addition and 1 deletion
Aug 28, 2016
seanmonstar commented on pull request hyperium/hyper#905
@seanmonstar

Oh you're right, it's used in the examples/hello.rs file. I had completely forgotten. Updating it doesn't hurt, in this case. The failing tests hav…

Aug 27, 2016
seanmonstar commented on pull request hyperium/hyper#905
@seanmonstar

Yes, master does not even use the num_cpus crate anymore.

Aug 26, 2016
seanmonstar commented on issue hyperium/hyper#904
@seanmonstar

You can do similar. Keep reading in to a Vec<u8> buffer until end of file, and then use your UTF_8.decode utility.

Aug 26, 2016
@seanmonstar
configure ssl
Aug 26, 2016
seanmonstar commented on issue hyperium/hyper#903
@seanmonstar

If you want to figure out how to get openssl building, look at https://github.com/sfackler/rust-openssl If you like to disable SSL, you can try thi…

Aug 26, 2016
seanmonstar commented on issue hyperium/hyper#904
@seanmonstar

Do you have a little more information? What is the exact code in on_response_readable that errors?

Aug 26, 2016
seanmonstar commented on pull request mozilla/fxa-oauth-server#412
@seanmonstar

Similar comment about the logging system.

Aug 25, 2016
seanmonstar commented on pull request mozilla/fxa-oauth-server#412
@seanmonstar

The logging system will turn the first argument into an op, and use the 2nd argument as the message details. Should be something like: logger.debug('…

Aug 24, 2016
seanmonstar commented on pull request hyperium/hyper#899
@seanmonstar

The spec claims this variant has "absolute-path [ "?" query ]". Maybe its worth adjusting the variant to AbsolutePath { path: String, query: Option…

Aug 24, 2016
seanmonstar commented on pull request hyperium/hyper#899
@seanmonstar

I'd be in favor of this test instead having 2 helpers, to prevent the proliferation of Some(...) in every test. Maybe something like: assert_eq!(parse

Aug 24, 2016
seanmonstar commented on pull request hyperium/hyper#899
@seanmonstar

Likewise, this one seems incorrect.

Aug 24, 2016
seanmonstar commented on pull request hyperium/hyper#899
@seanmonstar

This one is surprising. I would expect it to be a parse error.

Aug 24, 2016
seanmonstar commented on issue hyperium/hyper#902
@seanmonstar

I'm guessing you're looking for the Python http2 library. This is a Rust HTTP library. On Wed, Aug 24, 2016, 12:47 PM Pablo Liz notifications@githu…

Aug 24, 2016
seanmonstar commented on issue hyperium/hyper#900
@seanmonstar

Yep, seems this was changed when proxy support was added, which received tweaks to allow the host/port to be found from the original URL, even thou…

Aug 24, 2016
seanmonstar commented on issue hyperium/hyper#309
@seanmonstar

@untitaker this was part of the "async" commit, d35992d The specific logic is here: https://github.com/hyperium/hyper/blob/d35992d0198d733c251e133e…

Aug 24, 2016
seanmonstar commented on issue hyperium/hyper#897
@seanmonstar

You might want the query params, but not necessarily. A somewhat common usecase for a query string is as a cache buster, i.e. /foo/bar.js?abcdef, s…

Aug 24, 2016
seanmonstar commented on issue hyperium/hyper#901
@seanmonstar

@huachaohuang do you have a specific instance? This shouldn't be true, at least the exact steps you described. It's true that the Handlers will be …

Aug 24, 2016
Aug 24, 2016
@seanmonstar
Aug 24, 2016
Aug 24, 2016
@seanmonstar
Aug 24, 2016
Aug 24, 2016
@seanmonstar
Aug 24, 2016
seanmonstar commented on pull request servo/servo#13004
@seanmonstar

I wasn't aware that you were working with the raw bytes of the Header. In that case, it's likely more according to the spec to add a new 'line'. It…