New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css reset should not be inlined #26

Merged
merged 7 commits into from May 27, 2018

Conversation

Projects
None yet
6 participants
@lkrids
Copy link
Contributor

lkrids commented Jul 8, 2013

The css reset is styling or resetting elements that are added by email clients. These css rules shouldn't be inlined.

@jjb

This comment has been minimized.

Copy link

jjb commented on ac1323d Oct 28, 2013

hi @lkrids — could you explain this a bit, or point to something else that does? (i'm not doubting it, but i'm not experienced enough to know for sure if it's right)

@lkrids

This comment has been minimized.

Copy link
Contributor

lkrids commented Oct 28, 2013

@jjb I think the #outlook and .ExternalClass are added by Outlook and Hotmail respectively when those clients render the e-mail. Unless I'm missing something the #outlook and .ExternalClass don't exist when you go to inline css, before you send the e-mail.

@jjb

This comment has been minimized.

Copy link

jjb commented Oct 28, 2013

@lkrids ahhh, gotcha. have a reference handy?

@lkrids

This comment has been minimized.

Copy link
Contributor

lkrids commented Oct 28, 2013

@jjb I'm just going off of the comments in the code. There are no elements in the boilerplate with #outlook or .ExternalClass.

@smeric

This comment has been minimized.

Copy link

smeric commented Oct 10, 2015

hi,

this pr is a bit old and i'm not sure it's still valuable... but you may find some references here :
http://templates.mailchimp.com/development/css/client-specific-styles/

thanks for your work.

lkrids added some commits May 17, 2018

testing committing
this is a thorough description of the test I'm performing now.
copy updates
got email from team
asdf
asdf

@seanpowell seanpowell merged commit 8c8ebde into seanpowell:master May 27, 2018

@DanielRuf

This comment has been minimized.

Copy link

DanielRuf commented on e3c6a27 Oct 19, 2018

asdf?

This comment has been minimized.

Copy link

tchalvak replied Oct 20, 2018

Just someone doing a standard random test of web pull requests, close it.

This comment has been minimized.

Copy link

DanielRuf replied Oct 20, 2018

Well, it was merged and it is in master.

This comment has been minimized.

This comment has been minimized.

Copy link

tchalvak replied Oct 20, 2018

Oh no!

This comment has been minimized.

Copy link

tchalvak replied Oct 20, 2018

Here we go, opened a simple PR to revert that merge and reapply the single-word change that was the original intent.

tchalvak pushed a commit to BitLucid/Email-Boilerplate that referenced this pull request Oct 20, 2018

Roy Ronalds
Revert "Merge pull request seanpowell#26 from lkrids/master"
This reverts commit 8c8ebde, reversing
changes made to aba0d02.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment