Guard box_hide call on client_close #30
Merged
Conversation
seanpringle
added a commit
that referenced
this pull request
May 17, 2015
Guard box_hide call on client_close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I found that when I close Google Chrome (42.0.2311.152 64-bit) on Ubuntu (14.10, 15.04) using Mod-Escape, goomwwm crashes and leaves me back at the login screen. I swapped my install for a debug build and found the following in my syslog:
I used addr2line to lead me to box.c:67 (box_hide), and found the offending caller to be client_close. I've added a guard around the box_hide call (like in client_review_border). The segfault no-longer happens.