Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair interference #114

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Conversation

ator-dev
Copy link
Member

@ator-dev ator-dev commented Apr 12, 2023

  • Enable reparation of highlighting, when damaged by the website (in some cases)
    • Not guaranteed to be fully correct but is acceptable (see commit messages for details)
  • Additionally, correctly remove tabindex=0 from option menus when re-closed
  • Bump (patch) version to 1.13.4
    • Commit message incorrectly identifies change to minor version

Fixes #113

Related to #109

- Allow CLASSIC model to respond to character data changes which remove
  its highlighting
  - This is only correct to an extent, even at the time of reparation,
    since it does not look further up the tree to capture flows fully;
    as usual this is a best effort acceptable performance approach
- Allow PAINT model to notice when a highlighting id attribute has been
  removed, and replace it
- Bump minor version to 4
- Remove tabindex when match options are closed, returning the list
  fully to its hidden state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user I want highlight parity across text/image/video search pages ENHANCEMENT
1 participant