Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Language selector for search results #4

Closed
m-i-l opened this issue Nov 29, 2020 · 1 comment
Closed

Web: Language selector for search results #4

m-i-l opened this issue Nov 29, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@m-i-l
Copy link
Contributor

m-i-l commented Nov 29, 2020

For the Search and the Newest Pages functions, all results are shown irrespective of language (for Browse there is a language filter). It would be good to have a language selector on the Search and Newest Pages so that users could only show results in the specified language.

Not sure if there are any HTTP headers that could be used to set sensible defaults (e.g. not sure how widely use Accept-Language is).

Given the privacy policy, probably don't want to remember a user's setting this with a cookie.

@m-i-l m-i-l changed the title Language selector for search results Web: Language selector for search results Dec 4, 2020
@m-i-l m-i-l added the enhancement New feature or request label Dec 4, 2020
m-i-l added a commit that referenced this issue Oct 23, 2022
…code between queries, and share results template. Also implemented #4: Language selector for search results
m-i-l added a commit that referenced this issue Oct 23, 2022
…and extended to allow Browse results to be displayed via thisw template
@m-i-l
Copy link
Contributor Author

m-i-l commented Oct 29, 2022

All search results pages (including Newest Pages) now have a Filters button in the same position in the top left, and a Sort by dropdown in top right (where they were already on the Browse Sites page).

Filters for search results, and Newest pages, are:

Note that data quality issues limit the usefulness of Filters and Sort by:

  • Selecting a filter will make results that don't have a value for that filter disappear, e.g. 29% pages don't have a language set, most of those might be in English, but if you select the en filter those results will no longer appear.
  • Selecting an order for a sparsely populated field like published date won't make results without a published date disappear, but will mean that the majority which don't have a value for that field will appear at the end in no specific order.

Current stats are:

@m-i-l m-i-l closed this as completed Oct 29, 2022
m-i-l added a commit that referenced this issue Aug 13, 2023
…word range, for #4 Make filters dropdown smaller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant