Skip to content

Indexing: A site submitted via Quick Add but awaiting approval, then submitted again via Verified Add, won't be indexed until moderator approval #67

@m-i-l

Description

@m-i-l

Normally when a site is added via Verified Add it is indexed within 30 mins or so (depending on how long it takes to index). If a site is submitted via Quick Add first then a Verified Add also goes straight through, as long as the Quick Add process is complete. Conversely a Verified Add first followed by a Quick Add is also detected and handled. The issue here is a Quick Add which is still in progress first, and then a Verified Add before the moderator approval which completes the Quick Add process.

In this case the Verified Add was successful, but it wasn't indexed because it was awaiting moderator approval. The user also reported a 500 Server Error on completing payment, which I think is related. Also, the moderator approval reset the api_enabled, indexing_frequency and indexing_page_limit values to those for Quick Add rather than Verified Add, so they had to be restored to the Verified Add values.

Need to catch this combination and make sure the Verified Add fully overrides the Quick Add even if the Quick Add is incomplete.

For reference, the server error logs were:

[01/Jul/2022:19:10:18 +0000] "GET /admin/checkout/create-checkout-session/ HTTP/1.0" 200 83
...
[Fri Jul 01 19:11:59.787694 2022] [wsgi:error] [pid 10:tid 140074167523072] [client 172.18.0.1:45574]     f"The view function for {request.endpoint!r} did not", referer: https://checkout.stripe.com/
[Fri Jul 01 19:11:59.787716 2022] [wsgi:error] [pid 10:tid 140074167523072] [client 172.18.0.1:45574] TypeError: The view function for 'add.verified_success' did not return a valid response. The function either returned None or ended without a return statement., referer: https://checkout.stripe.com/
...
[01/Jul/2022:19:11:59 +0000] "GET /admin/add/success/?session_id=...

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions