Fixed test result time logic for undefined number #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation below:
writer.attrib('time',''+specResult.time || '0.0');
where we would have an operator precedence issue here because the "+" is evaluated before "||" so we will never have '0.0'.
A fix below:
writer.attrib('time',''+(specResult.time || '0.0'));
where I simply add a pair of brackets so the "||" will be evaluated first.
Thanks and regards,
Moom