Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASwazooAdaptor decodes an already decoded URI #674

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments
Closed

WASwazooAdaptor decodes an already decoded URI #674

GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Mar 25, 2015

The second bug is in WASwazooAdaptor>>requestUrlFor:. In this case WAUrl is fed 
the printString of the #uri (an instance of SwazooURI) as follows:

 requestUrlFor: aNativeRequest
       | url |
       url := ((WAUrl absolute: aNativeRequest uri printString)
               decodedWith: self codec).
       aNativeRequest isEncrypted
               ifTrue: [ url scheme: 'https' ].
       ^ url

The problem occurs because WAUrl class>>absolute: expects the url to be url 
encoded, but the printString for SwazooURI prints the decoded url. Again this 
causes problems when HTTP special characters are in the input url. The other 
adaptors feed the 'raw' encoded url string to WAUrl, but the Swazoo adaptor 
does not ... SwazooURI does not keep the encoded source url around, so in my 
workaround I changed SwazooURI printQueriesOn: to reencode the query parameters 
...

Original issue reported on code.google.com by philippe...@gmail.com on 6 Aug 2011 at 7:10

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 25, 2015

Original comment by philippe...@gmail.com on 7 Aug 2011 at 8:46

  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 25, 2015

Name: Seaside-Adaptors-Swazoo-pmm.41
Author: pmm
Time: 7 August 2011, 11:50:38 am
UUID: cf19fbc8-f169-4f81-842c-37dde69d9557
Ancestors: Seaside-Adaptors-Swazoo-DaleHenrichs.40

- Issue 674:    WASwazooAdaptor decodes an already decoded URI
- http://code.google.com/p/seaside/issues/detail?id=674

Original comment by philippe...@gmail.com on 7 Aug 2011 at 9:51

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant