New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish code: fix typos and replace AIT's with lambdas #1074
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1074 +/- ##
============================================
+ Coverage 39.58% 39.6% +0.01%
- Complexity 1134 1138 +4
============================================
Files 221 221
Lines 8832 8828 -4
Branches 1130 1130
============================================
Hits 3496 3496
+ Misses 4895 4891 -4
Partials 441 441
Continue to review full report at Codecov.
|
Are there any difference, except the code format ? |
It doesn't change the code format, instead, it replaces the annonymous inner types with lambdas and fixes some typos, if it's too trivial feel free to.close it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
This PR fix some typos and replace anonymous inner types with lambdas
Ⅱ. Does this pull request fix one issue?
no
Ⅲ. Why don't you add test cases (unit test/integration test)?
did not change logics, just polishing
Ⅳ. Describe how to verify it
CI pass
Ⅴ. Special notes for reviews
no