Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish code: fix typos and replace AIT's with lambdas #1074

Merged
merged 3 commits into from May 21, 2019
Merged

Polish code: fix typos and replace AIT's with lambdas #1074

merged 3 commits into from May 21, 2019

Conversation

kezhenxu94
Copy link
Member

Ⅰ. Describe what this PR did

This PR fix some typos and replace anonymous inner types with lambdas

Ⅱ. Does this pull request fix one issue?

no

Ⅲ. Why don't you add test cases (unit test/integration test)?

did not change logics, just polishing

Ⅳ. Describe how to verify it

CI pass

Ⅴ. Special notes for reviews

no

@codecov-io
Copy link

codecov-io commented May 20, 2019

Codecov Report

Merging #1074 into develop will increase coverage by 0.01%.
The diff coverage is 53.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1074      +/-   ##
============================================
+ Coverage      39.58%   39.6%   +0.01%     
- Complexity      1134    1138       +4     
============================================
  Files            221     221              
  Lines           8832    8828       -4     
  Branches        1130    1130              
============================================
  Hits            3496    3496              
+ Misses          4895    4891       -4     
  Partials         441     441
Impacted Files Coverage Δ Complexity Δ
server/src/main/java/io/seata/server/Server.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...in/java/io/seata/server/session/BranchSession.java 75.43% <0%> (ø) 34 <0> (ø) ⬇️
...eata/server/store/FileTransactionStoreManager.java 41.75% <33.33%> (ø) 19 <0> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 32.27% <50%> (+0.79%) 14 <5> (+4) ⬆️
...a/io/seata/server/lock/DefaultLockManagerImpl.java 86.31% <83.33%> (ø) 22 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 183915d...8ec96d0. Read the comment docs.

@zhangthen
Copy link
Contributor

Are there any difference, except the code format ?

@kezhenxu94
Copy link
Member Author

Are there any difference, except the code format ?

It doesn't change the code format, instead, it replaces the annonymous inner types with lambdas and fixes some typos, if it's too trivial feel free to.close it :)

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.LGTM.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 4f2dd84 into apache:develop May 21, 2019
@kezhenxu94 kezhenxu94 deleted the polish branch May 21, 2019 01:46
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.6.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants