New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug of refresh cluster #1222
fix bug of refresh cluster #1222
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1222 +/- ##
============================================
+ Coverage 43.5% 43.5% +<.01%
Complexity 1428 1428
============================================
Files 250 250
Lines 10218 10206 -12
Branches 1330 1318 -12
============================================
- Hits 4445 4440 -5
+ Misses 5188 5187 -1
+ Partials 585 579 -6
Continue to review full report at Codecov.
|
} | ||
for (InstanceInfo instance : instances) { | ||
addressSet.add(new InetSocketAddress(instance.getIPAddr(), instance.getPort())); | ||
if (CollectionUtils.isNotEmpty(instances)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if it is not the application we are concerned about, we should ignore it, so we add an application judgment in front of it, this parameter is passed in through the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #1160
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews