Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug of refresh cluster #1222

Merged
merged 2 commits into from Jun 19, 2019
Merged

fix bug of refresh cluster #1222

merged 2 commits into from Jun 19, 2019

Conversation

leizhiyuan
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1160

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@leizhiyuan leizhiyuan added this to the 0.7.0 milestone Jun 19, 2019
@codecov-io
Copy link

codecov-io commented Jun 19, 2019

Codecov Report

Merging #1222 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1222      +/-   ##
============================================
+ Coverage       43.5%   43.5%   +<.01%     
  Complexity      1428    1428              
============================================
  Files            250     250              
  Lines          10218   10206      -12     
  Branches        1330    1318      -12     
============================================
- Hits            4445    4440       -5     
+ Misses          5188    5187       -1     
+ Partials         585     579       -6
Impacted Files Coverage Δ Complexity Δ
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.77% <0%> (-0.79%) 24% <0%> (ø)
...in/java/io/seata/server/session/BranchSession.java 78.86% <0%> (-0.05%) 41% <0%> (ø)
...a/io/seata/core/rpc/netty/MessageCodecHandler.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...n/java/io/seata/rm/datasource/ConnectionProxy.java 9.63% <0%> (+0.11%) 4% <0%> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 47.03% <0%> (+0.34%) 19% <0%> (ø) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 80.78% <0%> (+1.46%) 58% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3b9e03...6ff3a37. Read the comment docs.

}
for (InstanceInfo instance : instances) {
addressSet.add(new InetSocketAddress(instance.getIPAddr(), instance.getPort()));
if (CollectionUtils.isNotEmpty(instances)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if it is not the application we are concerned about, we should ignore it, so we add an application judgment in front of it, this parameter is passed in through the file.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 6ec37c8 into apache:develop Jun 19, 2019
@leizhiyuan leizhiyuan modified the milestone: 0.7.0 Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic problems within the refreshCluster method
4 participants