Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enabled configuration for metrics #1266

Merged

Conversation

zhengyangyong
Copy link
Contributor

Signed-off-by: zhengyangyong yangyong.zheng@qq.com

Ⅰ. Describe what this PR did

add a new configuration enabled for metrics:

## metrics settings
metrics {
  enabled = true                                          <-------- new
  registry-type = "compact"
  # multi exporters use comma divided
  exporter-list = "prometheus"
  exporter-prometheus-port = 9898
}

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>
@codecov-io
Copy link

codecov-io commented Jul 3, 2019

Codecov Report

Merging #1266 into develop will decrease coverage by 0.03%.
The diff coverage is 62.5%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1266      +/-   ##
=============================================
- Coverage      49.47%   49.43%   -0.04%     
  Complexity      1651     1651              
=============================================
  Files            326      326              
  Lines          11439    11441       +2     
  Branches        1415     1416       +1     
=============================================
- Hits            5659     5656       -3     
- Misses          5153     5155       +2     
- Partials         627      630       +3
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/io/seata/server/metrics/MetricsManager.java 76.92% <62.5%> (-4.9%) 5 <2> (ø)
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-1.4%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5bf9d...8e08a36. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@CoffeeLatte007 CoffeeLatte007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoffeeLatte007 CoffeeLatte007 merged commit 97f133a into apache:develop Jul 3, 2019
@leizhiyuan leizhiyuan modified the milestone: 0.7.0 Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
add a new configuration enabled for metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants