Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify eureka registry serviceUrl with default port #1398

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@alicexiaoshi
Copy link
Contributor

commented Aug 4, 2019

Ⅰ. Describe what this PR did

modify eureka registry serviceUrl with default port

eureka default port is 8761.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

left a comment

LGTM

@codecov-io

This comment has been minimized.

Copy link

commented Aug 4, 2019

Codecov Report

Merging #1398 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1398      +/-   ##
=============================================
- Coverage      45.97%   45.95%   -0.03%     
  Complexity      1695     1695              
=============================================
  Files            345      345              
  Lines          12486    12486              
  Branches        1597     1597              
=============================================
- Hits            5741     5738       -3     
- Misses          6092     6094       +2     
- Partials         653      654       +1
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-1.05%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d209271...ea8b82c. Read the comment docs.

@slievrly slievrly merged commit 5b9a0fa into seata:develop Aug 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.