Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: StateMachine ServiceTask supports asynchronous execution #1844

Merged
merged 57 commits into from Nov 1, 2019

Conversation

long187
Copy link
Contributor

@long187 long187 commented Oct 30, 2019

Ⅰ. Describe what this PR did

Saga: StateMachine ServiceTask supports asynchronous execution

Ⅱ. Does this pull request fix one issue?

#1843

lorne.cl and others added 30 commits September 3, 2019 16:17
@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #1844 into develop will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1844      +/-   ##
=============================================
- Coverage      55.05%   55.05%   -0.01%     
- Complexity      2353     2356       +3     
=============================================
  Files            422      422              
  Lines          14271    14277       +6     
  Branches        1712     1713       +1     
=============================================
+ Hits            7857     7860       +3     
- Misses          5684     5687       +3     
  Partials         730      730
Impacted Files Coverage Δ Complexity Δ
.../statelang/parser/impl/ServiceTaskStateParser.java 83.33% <33.33%> (-16.67%) 2 <0> (ø)
...ga/statelang/domain/impl/ServiceTaskStateImpl.java 66.66% <33.33%> (-3.71%) 14 <1> (+1)
...server/store/file/FileTransactionStoreManager.java 59.86% <0%> (-0.33%) 29% <0%> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 50% <0%> (+0.4%) 28% <0%> (+1%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 85.02% <0%> (+0.48%) 68% <0%> (+1%) ⬆️

@slievrly slievrly changed the title Saga: StateMachine ServiceTask supports asynchronous execution feature: StateMachine ServiceTask supports asynchronous execution Oct 31, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhangthen zhangthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhangthen zhangthen merged commit 29f805a into apache:develop Nov 1, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants