Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: oracle insert sql use sysdate error. #2685

Merged
merged 23 commits into from Jul 8, 2020
Merged

bugfix: oracle insert sql use sysdate error. #2685

merged 23 commits into from Jul 8, 2020

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented May 13, 2020

Ⅰ. Describe what this PR did

insert into test(create_time) values(sysdate) error.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@zjinlei zjinlei added the Do Not Merge Do not merge into develop label May 13, 2020
@codecov-io
Copy link

codecov-io commented May 14, 2020

Codecov Report

Merging #2685 into develop will decrease coverage by 0.15%.
The diff coverage is 32.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2685      +/-   ##
=============================================
- Coverage      50.91%   50.75%   -0.16%     
+ Complexity      2815     2814       -1     
=============================================
  Files            558      558              
  Lines          17941    17946       +5     
  Branches        2129     2102      -27     
=============================================
- Hits            9134     9108      -26     
- Misses          7938     7944       +6     
- Partials         869      894      +25     
Impacted Files Coverage Δ Complexity Δ
...sqlparser/druid/oracle/OracleInsertRecognizer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...r/druid/postgresql/PostgresqlInsertRecognizer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/sqlparser/druid/mysql/MySQLInsertRecognizer.java 95.23% <75.00%> (-4.77%) 15.00 <0.00> (ø)
...va/io/seata/rm/datasource/exec/InsertExecutor.java 63.27% <100.00%> (ø) 45.00 <0.00> (ø)
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0.00%> (-9.53%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0.00%> (-7.41%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0.00%> (-5.27%) 3.00% <0.00%> (ø%)
... and 18 more

@zjinlei zjinlei added this to the 1.3.0 milestone May 16, 2020
@l81893521 l81893521 added module/rm-datasource rm-datasource module module/sqlparser sql-parser module labels May 18, 2020
@zjinlei zjinlei removed the Do Not Merge Do not merge into develop label May 20, 2020
…date

# Conflicts:
#	rm-datasource/src/main/java/io/seata/rm/datasource/exec/InsertExecutor.java
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #2685 into develop will decrease coverage by 0.14%.
The diff coverage is 32.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2685      +/-   ##
=============================================
- Coverage      50.16%   50.01%   -0.15%     
+ Complexity      3023     3022       -1     
=============================================
  Files            598      598              
  Lines          19310    19315       +5     
  Branches        2347     2321      -26     
=============================================
- Hits            9686     9661      -25     
- Misses          8663     8669       +6     
- Partials         961      985      +24     
Impacted Files Coverage Δ Complexity Δ
...sqlparser/druid/oracle/OracleInsertRecognizer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...r/druid/postgresql/PostgresqlInsertRecognizer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/sqlparser/druid/mysql/MySQLInsertRecognizer.java 93.02% <75.00%> (-4.54%) 15.00 <0.00> (ø)
...o/seata/rm/datasource/exec/BaseInsertExecutor.java 71.89% <100.00%> (ø) 83.00 <0.00> (-1.00)
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0.00%> (-9.53%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0.00%> (-7.41%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0.00%> (-5.27%) 3.00% <0.00%> (ø%)
... and 17 more

jsbxyyx and others added 8 commits June 9, 2020 10:44
…date

# Conflicts:
#	rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseInsertExecutor.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/exec/BatchInsertExecutorTest.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/exec/MySQLInsertExecutorTest.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/exec/OracleInsertExecutorTest.java
…date

# Conflicts:
#	rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseInsertExecutor.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/exec/BatchInsertExecutorTest.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/exec/MySQLInsertExecutorTest.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/exec/OracleInsertExecutorTest.java
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sysdate <-> Date

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 6637c17 into apache:develop Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module module/sqlparser sql-parser module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants