New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: oracle insert sql use sysdate error. #2685
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2685 +/- ##
=============================================
- Coverage 50.91% 50.75% -0.16%
+ Complexity 2815 2814 -1
=============================================
Files 558 558
Lines 17941 17946 +5
Branches 2129 2102 -27
=============================================
- Hits 9134 9108 -26
- Misses 7938 7944 +6
- Partials 869 894 +25 |
...eata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/mysql/MySQLInsertRecognizer.java
Outdated
Show resolved
Hide resolved
…date # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/InsertExecutor.java
Codecov Report
@@ Coverage Diff @@
## develop #2685 +/- ##
=============================================
- Coverage 50.16% 50.01% -0.15%
+ Complexity 3023 3022 -1
=============================================
Files 598 598
Lines 19310 19315 +5
Branches 2347 2321 -26
=============================================
- Hits 9686 9661 -25
- Misses 8663 8669 +6
- Partials 961 985 +24 |
…date # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseInsertExecutor.java # rm-datasource/src/test/java/io/seata/rm/datasource/exec/BatchInsertExecutorTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/exec/MySQLInsertExecutorTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/exec/OracleInsertExecutorTest.java
…date # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseInsertExecutor.java # rm-datasource/src/test/java/io/seata/rm/datasource/exec/BatchInsertExecutorTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/exec/MySQLInsertExecutorTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/exec/OracleInsertExecutorTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sysdate <-> Date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
insert into test(create_time) values(sysdate) error.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews