Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix use @EnableAutoDataSourceProxy startup failed #3230

Merged
merged 1 commit into from Oct 28, 2020
Merged

bugfix: fix use @EnableAutoDataSourceProxy startup failed #3230

merged 1 commit into from Oct 28, 2020

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Oct 28, 2020

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: fix use @EnableAutoDataSourceProxy startup failed

Ⅱ. Does this pull request fix one issue?

fix #3229

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly added this to the 1.4.0 milestone Oct 28, 2020
@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #3230 into develop will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3230      +/-   ##
=============================================
- Coverage      51.09%   51.08%   -0.02%     
+ Complexity      3279     3277       -2     
=============================================
  Files            612      612              
  Lines          20081    20082       +1     
  Branches        2507     2507              
=============================================
- Hits           10261    10259       -2     
- Misses          8799     8800       +1     
- Partials        1021     1023       +2     
Impacted Files Coverage Δ Complexity Δ
...ation/datasource/AutoDataSourceProxyRegistrar.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 54.63% <0.00%> (-0.52%) 28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 82.72% <0.00%> (-0.46%) 70.00% <0.00%> (-1.00%)

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit a6d8b16 into apache:develop Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seata-all + @EnableAutoDataSourceProxy startup failed.
4 participants