New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the logic of rollback to savepoint and release to savepoint #3413
bugfix: fix the logic of rollback to savepoint and release to savepoint #3413
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3413 +/- ##
=============================================
+ Coverage 51.47% 51.56% +0.09%
- Complexity 3351 3369 +18
=============================================
Files 617 617
Lines 20367 20419 +52
Branches 2549 2559 +10
=============================================
+ Hits 10483 10529 +46
- Misses 8830 8835 +5
- Partials 1054 1055 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the change to the 1.5.0.md in the path /change and /change/en-us
…bugfix-rollback-savepoint
# Conflicts: # changes/1.5.0.md
…bugfix-rollback-savepoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
修复 ConnectionProxy#rollback(savepoint) 和 ConnectionProxy#releaseSavepoint(savepoint) 的逻辑
把 undo_item/lock_key 和savepoint关联起来,然后rollback(savepoint)的时候,把savepoint对应的undo_item&lock_key的buffer清理掉,releaseSavepoint(savepoint)的时候,就把对应的undo_item&lock_key挪到上一个savepoint上。
Ⅱ. Does this pull request fix one issue?
fixes #3223
Ⅲ. Why don't you add test cases (unit test/integration test)?
困了。。。明天再补吧。。。
Ⅳ. Describe how to verify it
手写jdbc去开启事务,回滚到savepoint/releaseSavepoint?
Ⅴ. Special notes for reviews