Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix other orm could not get generated keys #4302

Merged

Conversation

GoodBoyCoder
Copy link
Contributor

@GoodBoyCoder GoodBoyCoder commented Jan 17, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

  • 添加RS缓存,防止由于不可scroll导致其他ORM获取不到自增主键值
  • add rs cache to avoid other orm could not get generated keys when use getGeneratedKeys()

Ⅱ. Does this pull request fix one issue?

fixes #4035

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022

Codecov Report

Merging #4302 (fd6e09d) into develop (3993984) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4302      +/-   ##
=============================================
- Coverage      48.52%   48.51%   -0.02%     
+ Complexity      3830     3829       -1     
=============================================
  Files            728      728              
  Lines          24470    24471       +1     
  Branches        3026     3027       +1     
=============================================
- Hits           11875    11872       -3     
- Misses         11329    11331       +2     
- Partials        1266     1268       +2     
Impacted Files Coverage Δ
...io/seata/rm/datasource/AbstractStatementProxy.java 84.37% <75.00%> (-1.34%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️

@funky-eyes funky-eyes added this to the 1.5.0 milestone Jan 18, 2022
@funky-eyes funky-eyes requested review from jsbxyyx and caohdgege and removed request for jsbxyyx January 18, 2022 12:35
@funky-eyes funky-eyes added module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug. labels Jan 18, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit a65097f into apache:develop Jan 24, 2022
@GoodBoyCoder GoodBoyCoder deleted the fix-generated-keys-not-scrollable branch April 26, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Springboot2.3.4 postgresql mybatis-plus3.2使用seta1.4.2 AT模式时无法获取自增id
4 participants