New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the error when service.vgroupMapping change #4471
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4471 +/- ##
=============================================
- Coverage 49.09% 48.98% -0.11%
+ Complexity 4032 4029 -3
=============================================
Files 730 730
Lines 25278 25279 +1
Branches 3126 3126
=============================================
- Hits 12411 12384 -27
- Misses 11545 11576 +31
+ Partials 1322 1319 -3
|
…ten/seata into bugfix_vgroupmapping_change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
修复运行中修改 service.vgroupMapping 导致请求仍然流向旧集群的问题。
Fixed an issue where modifying service.vgroupMapping on-the-fly caused requests to still flow to the old cluster.
Ⅱ. Does this pull request fix one issue?
fixes #4470
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews