Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the error when service.vgroupMapping change #4471

Merged
merged 5 commits into from Mar 17, 2022

Conversation

pengten
Copy link
Contributor

@pengten pengten commented Mar 15, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

修复运行中修改 service.vgroupMapping 导致请求仍然流向旧集群的问题。
Fixed an issue where modifying service.vgroupMapping on-the-fly caused requests to still flow to the old cluster.

Ⅱ. Does this pull request fix one issue?

fixes #4470

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #4471 (6a801a5) into develop (193a112) will decrease coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4471      +/-   ##
=============================================
- Coverage      49.09%   48.98%   -0.11%     
+ Complexity      4032     4029       -3     
=============================================
  Files            730      730              
  Lines          25278    25279       +1     
  Branches        3126     3126              
=============================================
- Hits           12411    12384      -27     
- Misses         11545    11576      +31     
+ Partials        1322     1319       -3     
Impacted Files Coverage Δ
...eata/core/rpc/netty/NettyClientChannelManager.java 66.41% <50.00%> (-5.13%) ⬇️
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (-15.39%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 50.71% <0.00%> (-6.12%) ⬇️
...erver/storage/file/session/FileSessionManager.java 53.59% <0.00%> (-0.66%) ⬇️
.../java/io/seata/spring/util/TCCBeanParserUtils.java 32.25% <0.00%> (+1.61%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Mar 15, 2022
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/core core module labels Mar 15, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit ac12355 into apache:develop Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/core core module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the service.vgroupMapping is changed, the client will throw an exception
4 participants