bugfix:fix key [transport.enableRmClientBatchSendRequest ] cache penetration #4678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tration if not configure in env or nacos seata.properties
…tration if not configure in env or nacos seata.properties
funky-eyes
reviewed
Jun 10, 2022
core/src/main/java/io/seata/core/rpc/netty/RmNettyRemotingClient.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/TmNettyRemotingClient.java
Outdated
Show resolved
Hide resolved
…tration if not configure in env or nacos seata.properties
Codecov Report
@@ Coverage Diff @@
## develop #4678 +/- ##
=============================================
- Coverage 48.44% 48.43% -0.01%
- Complexity 4035 4036 +1
=============================================
Files 735 735
Lines 25600 25612 +12
Branches 3161 3162 +1
=============================================
+ Hits 12401 12405 +4
- Misses 11860 11869 +9
+ Partials 1339 1338 -1
|
funky-eyes
reviewed
Jun 11, 2022
core/src/main/java/io/seata/core/rpc/netty/RmNettyRemotingClient.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/RmNettyRemotingClient.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Jun 11, 2022
core/src/main/java/io/seata/core/rpc/netty/RmNettyRemotingClient.java
Outdated
Show resolved
Hide resolved
funky-eyes
approved these changes
Jun 12, 2022
There was a problem hiding this comment.
LGTM
请把pr及作者信息按照已有登记示例,进行登记,并提交到此pr中
https://github.com/seata/seata/blob/develop/changes/zh-cn/develop.md
https://github.com/seata/seata/blob/develop/changes/en-us/develop.md
funky-eyes
added
type: bug
ok，已登记 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix key [transport.enableRmClientBatchSendRequest ] cache penetration if not configure in env or nacos seata.properties
Ⅱ. Does this pull request fix one issue?
fixes #4666
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews