Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize java doc warning #4925

Merged
merged 2 commits into from Sep 8, 2022

Conversation

renliangyu857
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize java doc warning and disable doclint because it is too strict

Ⅱ. Does this pull request fix one issue?

fixes #4806

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly changed the title optimize java doc warning optimize: optimize java doc warning Sep 8, 2022
@slievrly slievrly added this to the 1.6.0 milestone Sep 8, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit cb16176 into apache:develop Sep 8, 2022
@@ -715,6 +715,7 @@
<dependencySourceIncludes>
<dependencySourceInclude>io.seata:seata-*</dependencySourceInclude>
</dependencySourceIncludes>
<additionalparam>-Xdoclint:none</additionalparam>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个参数是什么啊?
IDEA里报红,我查了下最高版本的 maven-javadoc-plugin.jar 里的 plugin.xml 里,也没有显示有这个参数。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

倒是有这几个参数:

图片

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

optimize javadoc warnings
4 participants