New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Python 3.7 #243
Fix for Python 3.7 #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returning from a generator is the correct way to generate StopIteration here. Tests continue to pass.
|
@adrian-the-git, @josegonzalez @hb-alexbotello Thanks for fixing this. What is the state of this PR? I’d love to see the changes released, so that fuzzywuzzy works smoothly again with Python 3.7. |
|
I no longer work at SeatGeek and therefore have no commit rights (hurray offboarding!). Hopefully there is someone on the SG dev team that is reviewing PRs for OSS repositories, but it's not going to be me. |
|
Unfortunately, it seems no one has yet taken up the mantle in your place. |
|
Is it time to fork this project? |
|
Hey @garetht, I saw you making some changes in SeatGeek’s Python repos recently. Maybe someone at SeatGeek could have a look again? Else I’d also be happy to get involved and help as a maintainer of fuzzywuzzy in the long run. |
|
@hb-alexbotello thanks for the contribution! I'll try and contact the relevant people to get this published. |
|
Any updates on this @garetht? fuzzywuzzy seems to be entirely useless in a lot of use cases until this is fixed. |
|
Ah sorry I'm going to try and ask for credentials again to publish this myself. |
|
@haykkh @adrian-the-git @MariusMez 0.18 is now published |
Fixes #233
According to PEP 479, if raise StopIteration occurs directly in a generator, simply replace it with return.
This is both backwards and forwards compatible code.