Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Python 3.7 #243

Merged
merged 2 commits into from Nov 12, 2019
Merged

Fix for Python 3.7 #243

merged 2 commits into from Nov 12, 2019

Conversation

hb-alexbotello
Copy link
Contributor

Fixes #233

According to PEP 479, if raise StopIteration occurs directly in a generator, simply replace it with return.

This is both backwards and forwards compatible code.

Copy link

@adrian-the-git adrian-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning from a generator is the correct way to generate StopIteration here. Tests continue to pass.

@paulgoetze
Copy link

@adrian-the-git, @josegonzalez @hb-alexbotello Thanks for fixing this. What is the state of this PR? I’d love to see the changes released, so that fuzzywuzzy works smoothly again with Python 3.7.

@josegonzalez
Copy link
Contributor

I no longer work at SeatGeek and therefore have no commit rights (hurray offboarding!). Hopefully there is someone on the SG dev team that is reviewing PRs for OSS repositories, but it's not going to be me.

@hb-alexbotello
Copy link
Contributor Author

hb-alexbotello commented Sep 19, 2019

Unfortunately, it seems no one has yet taken up the mantle in your place.

@adrian-the-git
Copy link

Is it time to fork this project?

@paulgoetze
Copy link

Hey @garetht, I saw you making some changes in SeatGeek’s Python repos recently. Maybe someone at SeatGeek could have a look again? Else I’d also be happy to get involved and help as a maintainer of fuzzywuzzy in the long run.

@garetht garetht merged commit 1c018b7 into seatgeek:master Nov 12, 2019
@garetht
Copy link
Contributor

garetht commented Nov 12, 2019

@hb-alexbotello thanks for the contribution! I'll try and contact the relevant people to get this published.

@haykkh
Copy link

haykkh commented Feb 6, 2020

Any updates on this @garetht? fuzzywuzzy seems to be entirely useless in a lot of use cases until this is fixed.

@garetht
Copy link
Contributor

garetht commented Feb 13, 2020

Ah sorry I'm going to try and ask for credentials again to publish this myself.

@garetht
Copy link
Contributor

garetht commented Feb 13, 2020

@haykkh @adrian-the-git @MariusMez 0.18 is now published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python 3.7 yield changes PEP 479
7 participants