Skip to content

Loading…

Solumate Support on Heroku #20

Merged
merged 3 commits into from

2 participants

@theghostwhoforks

Reading redistogo url from ENV to support soulmate on heroku

@erwaller
SeatGeek member

I'm not opposed to supporting the setting of the redis url through the environment, but I'd prefer the env variable to just be REDIS_URL. Then in an initializer/bootstrap type location, you could just copy REDISTOGO_URL to REDIS_URL. Does that make sense?

@theghostwhoforks

It makes sense.
Closed the pull request by mistake. Reopening it.

@erwaller erwaller merged commit d4ae091 into seatgeek:master
@erwaller
SeatGeek member

Cool, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Showing with 4 additions and 4 deletions.
  1. +1 −1 lib/soulmate.rb
  2. +3 −3 soulmate.gemspec
View
2 lib/soulmate.rb
@@ -23,7 +23,7 @@ def redis=(url)
def redis
@redis ||= (
- url = URI(@redis_url || "redis://127.0.0.1:6379/0")
+ url = URI(@redis_url || ENV["REDIS_URL"] || "redis://127.0.0.1:6379/0")
::Redis.new({
:host => url.host,
View
6 soulmate.gemspec
@@ -67,7 +67,7 @@ Gem::Specification.new do |s|
s.add_runtime_dependency(%q<redis>, [">= 2.0"])
s.add_runtime_dependency(%q<vegas>, [">= 0.1.0"])
s.add_runtime_dependency(%q<sinatra>, [">= 1.0"])
- s.add_runtime_dependency(%q<json>, ["~> 1.4.6"])
+ s.add_runtime_dependency(%q<json>, [">= 1.4.6"])
else
s.add_dependency(%q<redis>, ["~> 2.1.1"])
s.add_dependency(%q<multi_json>, ["~> 1.0.3"])
@@ -81,7 +81,7 @@ Gem::Specification.new do |s|
s.add_dependency(%q<redis>, [">= 2.0"])
s.add_dependency(%q<vegas>, [">= 0.1.0"])
s.add_dependency(%q<sinatra>, [">= 1.0"])
- s.add_dependency(%q<json>, ["~> 1.4.6"])
+ s.add_dependency(%q<json>, [">= 1.4.6"])
end
else
s.add_dependency(%q<redis>, ["~> 2.1.1"])
@@ -96,7 +96,7 @@ Gem::Specification.new do |s|
s.add_dependency(%q<redis>, [">= 2.0"])
s.add_dependency(%q<vegas>, [">= 0.1.0"])
s.add_dependency(%q<sinatra>, [">= 1.0"])
- s.add_dependency(%q<json>, ["~> 1.4.6"])
+ s.add_dependency(%q<json>, [">= 1.4.6"])
end
end
Something went wrong with that request. Please try again.