Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Move threshold calculations to method #25

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
2 participants

My intention is to make flog suitable for using in CI services. This PR allows to have all calculated methods and classes scores in corresponding instance variables. So they could be used for further calculations.

Owner

zenspider commented Apr 8, 2013

Overall, this looks good. Just some nitpicky stuff.

@zenspider zenspider was assigned Apr 8, 2013

@zenspider good notice, thank you! I use Sublime and yep, I did not set trimming whitespaces.

@zenspider I fixed Readme and hoe config for it, check it please.

Owner

zenspider commented Apr 9, 2013

This looks fantastic... but you lost me at README.md. That has nothing to do with your functional changes to the code and honestly, I don't care about veneer. If you roll back the last two commits of the pull I'll happily merge the rest.

Thanks again. I like what you're doing and how you're doing it.

@zenspider done 😃

May be I was a lil bit fast with README but my point was that README should give any developer an example of how to use the gem (both in with Ruby code and command line), so I just added this example there. Nevertheless let's continue to work on flog, examples could be added later.

Owner

zenspider commented Apr 10, 2013

Done! Thank you very much.

@zenspider zenspider closed this Apr 10, 2013

@zenspider, but you didn't actually merge it... You just closed the PR...

Owner

zenspider commented Apr 10, 2013

I did. I work in perforce, not git. My sync script runs on the quarter hour so sometimes it takes a few.

You can see it here: https://github.com/seattlerb/flog/commits/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment