Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Test fixes #26

Closed
wants to merge 11 commits into
from

Conversation

Projects
None yet
2 participants
  1. Duplication of tests in #test_flog removed

  2. Fixed tests for #output_details_methods

Hm, I fetched original master branch to my repo like this http://jpablobr.com/past/pull-from-github-fork-from-the-original-repo but in this PR I see all previous commits (but file diff shows code changed only in last commits I actually made).

Should we close this one and reopen it with just last 3 commits?

OK, I got the reason – the think is that you didn't merge my pull request, I don't see my commits in time line or myself at Contributors list:

https://github.com/seattlerb/flog/commits/master
https://github.com/seattlerb/flog/contributors

Why you don't want to merge this PR in common way?

Owner

zenspider commented Apr 10, 2013

Can you jump on IRC? I'm in both #ruby-lang and #seattle.rb. Or PM

@ghost ghost assigned zenspider Apr 10, 2013

Owner

zenspider commented Apr 10, 2013

Probably better to start a topic branch off of master w/ the 3 commits.

Sorry. I'm not a huge fan of git.

@zenspider I mean that you didn't merge my commit but basically grab my code and commit it with just my username in comment. I can't see myself here: https://github.com/seattlerb/flog/graphs/contributors

Why it is like that? You just need to hit "Merge Pull Request" and that's it! How can I say that "I am a contributor of flog" without my name in contributors list? I found it unfair. You must give some respect to contributors by merging PRs normally. I hope you understand what I mean 😃

@zenspider find me at #seattle.rb IRC chat

Owner

zenspider commented Apr 11, 2013

On Apr 11, 2013, at 12:23 , Anatoli Makarevich notifications@github.com wrote:

@zenspider find me at #seattle.rb IRC chat

I'm there now. I don't see you. Timezones are dumb. :(

@zenspider ping, I am there)

Moved to #27

@makaroni4 makaroni4 closed this Apr 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment