Is x.rb in the project for a good reason? #252

Closed
tmiller opened this Issue Mar 15, 2013 · 7 comments

2 participants

@tmiller

Looking up in history it looks like @zenspider introduced it when moving minitest/excludes.rb into its own gem. x.rb doesn't seem to be mentioned in Manifest.txt. Shouldn't this be removed?

@zenspider
Seattle Ruby Brigade member

It is a git-ism. I don't actually code in git and the sync script seems to not want to deal with this properly.

@zenspider zenspider was assigned Mar 18, 2013
@zenspider
Seattle Ruby Brigade member

I don't think I can fix this without doing a complete history rewrite and forcing every fork owner to do a git pull -f. :/

@tmiller

I think simply removing it with git rm and moving forward we will all agree to just pretend it never happend. ;)

@tmiller

I'm sorry I should have elaborated. If someone has linked to any of the commit sha's on Github that are affected by the rewrite after a month they will become dead links because of git's garbage collection. Also, removing it from history won't remove it from the released gem versions. It is just "safer" to bite the bullet and leave it in history, than to make it right in history and break links.

@zenspider
Seattle Ruby Brigade member
@tmiller

Sorry, I don't do much gem development and did not realize this. Thanks for pointing it out.

@postmodern postmodern referenced this issue Apr 17, 2013
Closed

Examples #265

@zenspider
Seattle Ruby Brigade member

I just did a force push to fix this. I think the version of git-p4 I was using was old and having problems. Hopefully a newer version will avoid some of this mess. Thanks for your patience.

@zenspider zenspider closed this Apr 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment