Namespace PrideIO and PrideLOL #261

Closed
postmodern opened this Issue Apr 11, 2013 · 5 comments

4 participants

@postmodern

Since minitest is imported into Ruby stdlib, minitest/pride.rb introduces two global constants (PrideIO and PrideLOL). These classes should probably be namespaced under MiniTest.

@zzak

Only when you require 'minitest/pride' right?

@zenspider
Seattle Ruby Brigade member

No

@zenspider zenspider closed this Apr 11, 2013
@zenspider
Seattle Ruby Brigade member

@zzak, just ignore him.

@postmodern

See Pull Request #266.

@jc00ke

@zenspider can you share your thoughts as to why you don't want it under the MiniTest namespace? I'm curious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment