some test cases are failing with ruby 1.9.1 #8

Closed
pravi opened this Issue Sep 1, 2011 · 6 comments

Comments

Projects
None yet
3 participants

pravi commented Sep 1, 2011

I'm building a debian package for ruby_parser and I got test failures during that, all tests pass with ruby 1.8 bu 6 tests fail with ruby 1.9.1. Details given below

Running tests for ruby1.8 with test file list from debian/ruby-test-files.yaml ...
Run options: --seed 57626

Running tests:

................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Finished tests in 0.295260s, 2330.1497 tests/s, 12903.8813 assertions/s.

688 tests, 3810 assertions, 0 failures, 0 errors, 0 skips

/usr/bin/ruby1.9.1 -I/usr/lib/ruby/vendor_ruby /usr/lib/ruby/vendor_ruby/gem2deb/test_runner.rb
Running tests for ruby1.9.1 with test file list from debian/ruby-test-files.yaml ...
Run options: --seed 7076

Running tests:

.............................................................................................................................................................................................................................................................................................................................E...............E..............................................E....................E........E.........................................................................F..................................E.............................................E................................E................F......F...FF............E..............F....................E......................

Finished tests in 0.214555s, 3257.9026 tests/s, 17869.5258 assertions/s.

  1. Error:
    test_lambda_args_2__19(TestRubyParser):
    Racc::ParseError:
    parse error on value ">" (tGT)
    /usr/lib/ruby/1.9.1/racc/parser.rb:349:in on_error' /usr/lib/ruby/1.9.1/racc/parser.rb:99:in_racc_do_parse_c'
    /usr/lib/ruby/1.9.1/racc/parser.rb:99:in do_parse' /media/forge/debian/diaspora/ruby-parser-2.2.0/debian/ruby-parser/usr/lib/ruby/vendor_ruby/ruby_parser_extras.rb:760:inprocess'
    /media/forge/debian/diaspora/ruby-parser-2.2.0/test/test_ruby_parser.rb:15:in `process'

  2. Error:
    test_defn_args_splat_mand__19(TestRubyParser):
    Racc::ParseError:
    parse error on value "mand" (tIDENTIFIER)
    /usr/lib/ruby/1.9.1/racc/parser.rb:349:in on_error' /usr/lib/ruby/1.9.1/racc/parser.rb:99:in_racc_do_parse_c'
    /usr/lib/ruby/1.9.1/racc/parser.rb:99:in do_parse' /media/forge/debian/diaspora/ruby-parser-2.2.0/debian/ruby-parser/usr/lib/ruby/vendor_ruby/ruby_parser_extras.rb:760:inprocess'
    /media/forge/debian/diaspora/ruby-parser-2.2.0/test/test_ruby_parser.rb:15:in `process'

  3. Error:
    test_defn_args_splat_middle__19(TestRubyParser):
    Racc::ParseError:
    parse error on value "last" (tIDENTIFIER)
    /usr/lib/ruby/1.9.1/racc/parser.rb:349:in on_error' /usr/lib/ruby/1.9.1/racc/parser.rb:99:in_racc_do_parse_c'
    /usr/lib/ruby/1.9.1/racc/parser.rb:99:in do_parse' /media/forge/debian/diaspora/ruby-parser-2.2.0/debian/ruby-parser/usr/lib/ruby/vendor_ruby/ruby_parser_extras.rb:760:inprocess'
    /media/forge/debian/diaspora/ruby-parser-2.2.0/test/test_ruby_parser.rb:15:in `process'

  4. Error:
    test_lambda_args_no__19(TestRubyParser):
    Racc::ParseError:
    parse error on value ">" (tGT)
    /usr/lib/ruby/1.9.1/racc/parser.rb:349:in on_error' /usr/lib/ruby/1.9.1/racc/parser.rb:99:in_racc_do_parse_c'
    /usr/lib/ruby/1.9.1/racc/parser.rb:99:in do_parse' /media/forge/debian/diaspora/ruby-parser-2.2.0/debian/ruby-parser/usr/lib/ruby/vendor_ruby/ruby_parser_extras.rb:760:inprocess'
    /media/forge/debian/diaspora/ruby-parser-2.2.0/test/test_ruby_parser.rb:15:in `process'

  5. Error:
    test_fcall_arglist_hash_colons__19(TestRubyParser):
    Racc::ParseError:
    parse error on value ":" (tCOLON)
    /usr/lib/ruby/1.9.1/racc/parser.rb:349:in on_error' /usr/lib/ruby/1.9.1/racc/parser.rb:99:in_racc_do_parse_c'
    /usr/lib/ruby/1.9.1/racc/parser.rb:99:in do_parse' /media/forge/debian/diaspora/ruby-parser-2.2.0/debian/ruby-parser/usr/lib/ruby/vendor_ruby/ruby_parser_extras.rb:760:inprocess'
    /media/forge/debian/diaspora/ruby-parser-2.2.0/test/test_ruby_parser.rb:15:in `process'

  6. Failure:
    test_str_question_literal__19(TestRubyParser) [/usr/lib/ruby/vendor_ruby/pt_testcase.rb:136]:
    failed on input: "?a".
    Expected s(:str, "a"), not s(:lit, 97).line(1).

  7. Error:
    test_lambda_args_0__19(TestRubyParser):
    Racc::ParseError:
    parse error on value ">" (tGT)
    /usr/lib/ruby/1.9.1/racc/parser.rb:349:in on_error' /usr/lib/ruby/1.9.1/racc/parser.rb:99:in_racc_do_parse_c'
    /usr/lib/ruby/1.9.1/racc/parser.rb:99:in do_parse' /media/forge/debian/diaspora/ruby-parser-2.2.0/debian/ruby-parser/usr/lib/ruby/vendor_ruby/ruby_parser_extras.rb:760:inprocess'
    /media/forge/debian/diaspora/ruby-parser-2.2.0/test/test_ruby_parser.rb:15:in `process'

  8. Error:
    test_lambda_args_2_no_parens__19(TestRubyParser):
    Racc::ParseError:
    parse error on value ">" (tGT)
    /usr/lib/ruby/1.9.1/racc/parser.rb:349:in on_error' /usr/lib/ruby/1.9.1/racc/parser.rb:99:in_racc_do_parse_c'
    /usr/lib/ruby/1.9.1/racc/parser.rb:99:in do_parse' /media/forge/debian/diaspora/ruby-parser-2.2.0/debian/ruby-parser/usr/lib/ruby/vendor_ruby/ruby_parser_extras.rb:760:inprocess'
    /media/forge/debian/diaspora/ruby-parser-2.2.0/test/test_ruby_parser.rb:15:in `process'

  9. Error:
    test_call_arglist_norm_hash_colons__19(TestRubyParser):
    Racc::ParseError:
    parse error on value ":" (tCOLON)
    /usr/lib/ruby/1.9.1/racc/parser.rb:349:in on_error' /usr/lib/ruby/1.9.1/racc/parser.rb:99:in_racc_do_parse_c'
    /usr/lib/ruby/1.9.1/racc/parser.rb:99:in do_parse' /media/forge/debian/diaspora/ruby-parser-2.2.0/debian/ruby-parser/usr/lib/ruby/vendor_ruby/ruby_parser_extras.rb:760:inprocess'
    /media/forge/debian/diaspora/ruby-parser-2.2.0/test/test_ruby_parser.rb:15:in `process'

  10. Failure:
    test_call_not_equal__19(TestRubyParser) [/usr/lib/ruby/vendor_ruby/pt_testcase.rb:136]:
    failed on input: "a != b".
    Expected s(:call, s(:call, nil, :a, s(:arglist)), :!=, s(:arglist, s(:call, nil, :b, s(:arglist)))), not s(:not, s(:call, s(:call, nil, :a, s(:arglist).line(1)).line(1), :==, s(:arglist, s(:call, nil, :b, s(:arglist).line(1)).line(1)).line(1)).line(1)).line(1).

  11. Failure:
    test_hash_new__19(TestRubyParser) [/usr/lib/ruby/vendor_ruby/pt_testcase.rb:136]:
    failed on input: "{ a: 1, b: 2 }".
    Expected s(:hash, s(:lit, :a), s(:lit, 1), s(:lit, :b), s(:lit, 2)), not nil.

  12. Failure:
    test_str_question_escape__19(TestRubyParser) [/usr/lib/ruby/vendor_ruby/pt_testcase.rb:136]:
    failed on input: "?\n".
    Expected s(:str, "\n"), not s(:lit, 10).line(1).

  13. Failure:
    test_str_question_control__19(TestRubyParser) [/usr/lib/ruby/vendor_ruby/pt_testcase.rb:136]:
    failed on input: "?\M-\C-a".
    Expected s(:str, "\x81"), not s(:lit, 129).line(1).

  14. Error:
    test_lambda_args_1__19(TestRubyParser):
    Racc::ParseError:
    parse error on value ">" (tGT)
    /usr/lib/ruby/1.9.1/racc/parser.rb:349:in on_error' /usr/lib/ruby/1.9.1/racc/parser.rb:99:in_racc_do_parse_c'
    /usr/lib/ruby/1.9.1/racc/parser.rb:99:in do_parse' /media/forge/debian/diaspora/ruby-parser-2.2.0/debian/ruby-parser/usr/lib/ruby/vendor_ruby/ruby_parser_extras.rb:760:inprocess'
    /media/forge/debian/diaspora/ruby-parser-2.2.0/test/test_ruby_parser.rb:15:in `process'

  15. Failure:
    test_call_unary_not__19(TestRubyParser) [/usr/lib/ruby/vendor_ruby/pt_testcase.rb:136]:
    failed on input: "!a".
    Expected s(:call, s(:call, nil, :a, s(:arglist)), :"!@", s(:arglist)), not s(:not, s(:call, nil, :a, s(:arglist).line(1)).line(1)).line(1).

  16. Error:
    test_splat_fcall_middle__19(TestRubyParser):
    Racc::ParseError:
    parse error on value 3 (tINTEGER)
    /usr/lib/ruby/1.9.1/racc/parser.rb:349:in on_error' /usr/lib/ruby/1.9.1/racc/parser.rb:99:in_racc_do_parse_c'
    /usr/lib/ruby/1.9.1/racc/parser.rb:99:in do_parse' /media/forge/debian/diaspora/ruby-parser-2.2.0/debian/ruby-parser/usr/lib/ruby/vendor_ruby/ruby_parser_extras.rb:760:inprocess'
    /media/forge/debian/diaspora/ruby-parser-2.2.0/test/test_ruby_parser.rb:15:in `process'

699 tests, 3834 assertions, 6 failures, 10 errors, 0 skips

Test "ruby1.9.1" failed. Continue building the package? (Y/N) n

Owner

zenspider commented Sep 1, 2011

Yup. That's intentional. What's the problem?

@zenspider zenspider closed this Sep 1, 2011

Owner

zenspider commented Sep 1, 2011

P.S. Nobody supports ruby 1.9.1... why do you? It is ancient, buggy, officially unsupported, and crap. Maybe debian should focus on being a first class ruby citizen and support ruby 1.9.2. Even falling back to ruby 1.8.7 is a much better decision than using ruby 1.9.1.

pravi commented Sep 2, 2011

ruby1.9.1 binary is actually 1.9.2 (sorry for the confusion, I'm new member of debian ruby team and still learning), I'm reopening this as failure is with ruby 1.9.2

$ ruby1.9.1 -v
ruby 1.9.2p290 (2011-07-09 revision 32553) [x86_64-linux]

Also debian have 1.9.3 (1.9.3~preview1+svn33077-3) in experimental and next debian release will include this as default (current plan - policy is latest upstream release version).

LucasNussbaum’s blog has some clarifications about ruby in debian http://www.lucas-nussbaum.net/blog/?p=566

pravi commented Sep 2, 2011

looks like I can't reopen this :(

The tests specific to Ruby 1.9 are failing because RubyParser does not yet support the new syntactical constructs in 1.9. So this is the expected result and should not impede building the Debian package.

pravi commented Sep 2, 2011

thanks presidentbeef, I will go ahead and build debian package disabling tests for ruby 1.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment