Unix Socket listener for S3 server#4621
Merged
Merged
Conversation
kmlebedev
pushed a commit
to kmlebedev/seaweedfs
that referenced
this pull request
Dec 22, 2023
Add localSocket option to s3 server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
As it suggested by wiki, S3 servers commonly running behind a reverse-proxy server like nginx and currently the connection between the two established using OS loop-back.
Unix socket are proven to be more efficient and robust than lo and using them alongside tcp port listening can help busy servers.
How are we solving the problem?
Basically I copy-pasted your previous commit about adding Unix domain sockets to filer server with required changes.
How is the PR tested?
I built the project and spin up an instance and test the connection between nginx & s3 server.
Unix socket listening on
/tmp/seaweedfs-s3-%port%.sockby default.Checks