Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Toggle selector #33

Closed
ulde01 opened this issue Mar 18, 2019 · 4 comments
Closed

Updated Toggle selector #33

ulde01 opened this issue Mar 18, 2019 · 4 comments
Assignees
@modsmoss
Labels
released on @next released

Comments

@ulde01
Copy link

ulde01 commented Mar 18, 2019 •
edited
Loading

Design change 2019-03-13

The design update on Toggle selector was reviewed March 13:

Change

  • Updated name: from Toggle button to Toggle selector
  • Updated identifier: component-toggleselector
  • Updated description of use
  • Updated size and colours

See the details in the description: https://designlibrary.sebgroup.com/components/toggle-selector/

Reason
Analytics showed that the component was overlooked by users. It was unclear that the component was clickable.

image

Thanks!
/Ulrika,
Design Management
@ulde01 ulde01 mentioned this issue Mar 18, 2019
Closed
4 tasks
@ulde01
Copy link
Author

ulde01 commented Mar 18, 2019

Please see the link above for the specification of colours, etc.

@modsmoss modsmoss self-assigned this Mar 22, 2019
modsmoss added a commit that referenced this issue Mar 22, 2019
@modsmoss
refactor(toggle-button/toggle-selector): change name of the component
ada7ed4 
The component has changed name from toggle-button to toggle-selector

BREAKING CHANGE: The mixin and the css class has changed name from ..button to ..selector

fix #33
@modsmoss modsmoss mentioned this issue Mar 22, 2019
Merged
@ulde01
Copy link
Author

ulde01 commented Apr 4, 2019

Duplicate of #21

@ulde01 ulde01 marked this as a duplicate of #21 Apr 4, 2019
@ulde01 ulde01 closed this as completed Apr 4, 2019
@sebopensource
Copy link

🎉 This issue has been resolved in version 3.0.0-pre.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sebopensource
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@modsmoss modsmoss

Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@modsmoss @sebopensource @ulde01