Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDerive std traits for Target. #18
Conversation
src/lib.rs
Outdated
| @@ -157,7 +157,7 @@ mod filter; | |||
| mod filter; | |||
|
|
|||
| /// Log target, either stdout or stderr. | |||
| #[derive(Debug)] | |||
| #[derive(Clone, Copy, Debug, Eq, Hash, Ord, PartialEq, PartialOrd)] | |||
This comment has been minimized.
This comment has been minimized.
KodrAus
Sep 1, 2017
Collaborator
Hmm, Ord and PartialOrd probably don't make sense for this enum. I think we should remove them, but the rest look good.
This comment has been minimized.
This comment has been minimized.
mjkillough
Sep 1, 2017
Author
Contributor
Sorry, I'd missed your comment on #6. I agree: I don't think they make sense, so I've removed them in the latest commit.
This comment has been minimized.
This comment has been minimized.
|
@KodrAus - Thanks a lot for the review! Hopefully the latest commit addresses your comment. Please can you take another look? |
KodrAus
approved these changes
Sep 1, 2017
|
This looks good to me now! Thanks. @sebasmagri Are you happy for me to merge this in? |
This comment has been minimized.
This comment has been minimized.
|
Sure @KodrAus! Thanks! |
KodrAus
merged commit 5451f90
into
sebasmagri:master
Sep 1, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mjkillough commentedAug 22, 2017
Fixes #6.