Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to the latest commit of `log` / deny debug impls, missing docs, and warnings. #24
Conversation
jimmycuadra
added some commits
Oct 12, 2017
This comment has been minimized.
This comment has been minimized.
|
Awesome, thanks @jimmycuadra! |
KodrAus
merged commit 13f6f60
into
sebasmagri:master
Oct 12, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
jimmycuadra
deleted the
jimmycuadra:log-head-and-lints
branch
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jimmycuadra commentedOct 12, 2017
I was adding a deny attribute for missing debug impls, missing docs, and warnings, and discovered the crate doesn't compile against the latest API changes to
log's master branch, so I updated that too.