Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds a new constructor and init functions for custom env vars. #25
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks again @jimmycuadra! I think this looks good. There probably isn't a whole lot of value testing the environment vars, since they just hand off to |
KodrAus
merged commit 3d1afe8
into
sebasmagri:master
Oct 13, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
jimmycuadra
deleted the
jimmycuadra:from-env
branch
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jimmycuadra commentedOct 12, 2017
Three new methods/functions that are like existing ones, but allow you to specify the name of the environment variable to parse:
Logger::from_env, which is likeLogger::new.init_from_env, which is likeinit.try_init_from_env, which is liketry_init.I also changed the docs for the init functions slightly to make it clearer what the difference is between them all when reading the docs for the crate root.
I haven't added any new tests, but I'd be happy to if desired. Let me know if there is a preferred way of working with environment variables to keep tests deterministic.
Refs #23
Refs rust-lang-nursery/log#83