Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd examples for custom format and logger impls #27
Conversation
This comment has been minimized.
This comment has been minimized.
|
r? @jimmycuadra |
This comment has been minimized.
This comment has been minimized.
|
Nice additions! |
KodrAus
merged commit fdd248a
into
master
Oct 17, 2017
KodrAus
deleted the
chore/custom_examples
branch
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
KodrAus commentedOct 16, 2017
I think it would be good for use to build up a set of complete cargo examples. Here I've added two:
Vec<String>or something?)These seem like good ones to start with because they use some new APIs we've introduced. We can use them to drive any changes we want to make to those APIs to make them a bit more ergonomic.