Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd rfc3339 timestamps to default format #33
Conversation
This comment has been minimized.
This comment has been minimized.
|
r? @mjkillough |
KodrAus
merged commit a897069
into
master
Nov 5, 2017
This comment has been minimized.
This comment has been minimized.
|
@KodrAus - Apologies for the late review, I was on holiday until this afternoon. This looks great! :) I didn't realise how great the formatting in |
This comment has been minimized.
This comment has been minimized.
|
Well, since the UTC time is used anyway (which is a good thing), I think In my opinion |
This comment has been minimized.
This comment has been minimized.
|
Thanks @mjkillough and @tailhook! The |
This comment has been minimized.
This comment has been minimized.
|
Added #34 to sort the format out. |
KodrAus commentedNov 1, 2017
Closes #30
Adds RFC3339 formatted timestamps to the default log format:
I've made an effort to avoid allocating temporary strings or needing to parse a format for each log, so there's a currently private
Timestampstruct that can be pulled off aFormatterthat does this.