Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMake the timestamp format more compact #36
Conversation
This comment has been minimized.
This comment has been minimized.
|
r? @mjkillough |
This comment has been minimized.
This comment has been minimized.
|
Oops! I forgot to update our example formatted log records. |
KodrAus
merged commit e88337e
into
master
Nov 12, 2017
This comment has been minimized.
This comment has been minimized.
|
Looks great. I don't think a configurable format is much needed. Any blockers for a release? |
This comment has been minimized.
This comment has been minimized.
|
@tailhook We're just waiting on an |
KodrAus
deleted the
feat/compact-timestamps
branch
Nov 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
KodrAus commentedNov 9, 2017
Fixes #34
Makes the RFC3339 timestamp format more compact. This is still just using a hardcoded set of
chrono::format::Items. I think we'll definitely want to make this configurable in the future somehow.