Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable use of Logger as a filter #4
Conversation
This comment has been minimized.
This comment has been minimized.
|
@jethrogb it looks good to me initially. However, could you please add an example or a few documentation lines explaining how to use this with your own logger? |
sebasmagri
requested a review
from
sfackler
Jul 12, 2017
This comment has been minimized.
This comment has been minimized.
|
Added docs |
jethrogb
force-pushed the
jethrogb:filter
branch
from
3a5b1f9
to
1e87fdc
Jul 12, 2017
This comment has been minimized.
This comment has been minimized.
|
Hi @jethrogb! Could you please review and rebase changes against the latest master to merge this? |
jethrogb
force-pushed the
jethrogb:filter
branch
from
1e87fdc
to
1eaa005
Aug 22, 2017
This comment has been minimized.
This comment has been minimized.
|
Rebased |
jethrogb
force-pushed the
jethrogb:filter
branch
from
1eaa005
to
d7e6104
Aug 22, 2017
jethrogb
closed this
Aug 22, 2017
jethrogb
reopened this
Aug 22, 2017
jethrogb
force-pushed the
jethrogb:filter
branch
from
d7e6104
to
0a02e98
Aug 22, 2017
jethrogb
force-pushed the
jethrogb:filter
branch
2 times, most recently
from
70b8b29
to
a60b5c4
Sep 11, 2017
This comment has been minimized.
This comment has been minimized.
|
Rebased, again. Can you please either accept or decline this PR so I don't have to keep rebasing it? |
KodrAus
self-requested a review
Sep 12, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks for this @jethrogb! Sorry about the delay, I'll give this a proper review this week. You won't need to rebase again. |
KodrAus
approved these changes
Sep 15, 2017
|
Thanks again for doing this @jethrogb! I think this is a good start and will merge it in once the build is green. We might want to add some dedicated APIs over the builder before the next release so you can parse a filter for your own loggers without having to set a target explicitly. |
added some commits
Sep 11, 2017
jethrogb
force-pushed the
jethrogb:filter
branch
from
a60b5c4
to
dd8e1be
Sep 15, 2017
This comment has been minimized.
This comment has been minimized.
Fixed. Probably should've run
You don't have to set it. If you only call |
This comment has been minimized.
This comment has been minimized.
Ah you're right. Having a silent target is a prerequisite to anything else we'd want to do here anyway so there's no reason to block this on thinking about other ways to expose the filtering. Thanks again! |
jethrogb commentedJul 12, 2017
The spec parsing and matching of env_logger is very useful, but it will only let you log to stdout/stderr. With this change you can embed env_logger's logic in your own logger.