From 3a3cd121ce7cd032f94fb8f881ba3b5f145e3f40 Mon Sep 17 00:00:00 2001 From: Sebastian Bergmann Date: Thu, 4 Apr 2024 10:53:00 +0200 Subject: [PATCH] Fix issues identified by Psalm --- src/Parser.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Parser.php b/src/Parser.php index ab2d975..32148c9 100644 --- a/src/Parser.php +++ b/src/Parser.php @@ -53,7 +53,7 @@ public function parse(array $argv, string $shortOptions, ?array $longOptions = n $options = []; $nonOptions = []; - if ($longOptions) { + if ($longOptions !== null) { sort($longOptions); } @@ -82,7 +82,7 @@ public function parse(array $argv, string $shortOptions, ?array $longOptions = n break; } - if ($arg[0] !== '-' || (strlen($arg) > 1 && $arg[1] === '-' && !$longOptions)) { + if ($arg[0] !== '-' || (strlen($arg) > 1 && $arg[1] === '-' && $longOptions === null)) { $nonOptions[] = $arg; continue; @@ -135,7 +135,7 @@ private function parseShortOption(string $argument, string $shortOptions, array if (!(strlen($spec) > 2 && $spec[2] === ':')) { $optionArgument = current($argv); - if (!$optionArgument) { + if ($optionArgument === false) { throw new RequiredOptionArgumentMissingException('-' . $option); } @@ -191,7 +191,7 @@ private function parseLongOption(string $argument, array $longOptions, array &$o next($argv); } - } elseif ($optionArgument) { + } elseif ($optionArgument !== null) { throw new OptionDoesNotAllowArgumentException('--' . $option); }