Skip to content

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Nov 10, 2025

analog #1105 but for regular line coverage data

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 82.60870% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.83%. Comparing base (37047b5) to head (1319902).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Node/File.php 66.88% 50 Missing ⚠️
src/Report/Html/Renderer/Dashboard.php 92.30% 3 Missing ⚠️
src/Node/AbstractNode.php 0.00% 2 Missing ⚠️
src/Data/ProcessedTraitType.php 0.00% 1 Missing ⚠️
src/Report/Clover.php 94.11% 1 Missing ⚠️
src/Report/Crap4j.php 90.90% 1 Missing ⚠️
src/Report/OpenClover.php 94.44% 1 Missing ⚠️
src/Report/Xml/Facade.php 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1109   +/-   ##
=========================================
  Coverage     88.82%   88.83%           
- Complexity     1391     1396    +5     
=========================================
  Files            98      102    +4     
  Lines          4655     4658    +3     
=========================================
+ Hits           4135     4138    +3     
  Misses          520      520           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@staabm
Copy link
Contributor Author

staabm commented Nov 10, 2025

very interessting.. this PR does not yet yield a measurable performance improvement in the cases I tested. neither perf nor memory wise.

still its a improvement regarding maintainability and readability.

@sebastianbergmann
Copy link
Owner

Why is this still a draft? Thanks.

@staabm
Copy link
Contributor Author

staabm commented Nov 11, 2025

because it did not yield the expected perf results. if you are fine with the change we can still go ahead

@staabm staabm marked this pull request as ready for review November 11, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants