foreach and while are not counted as LLOC

[gooh]

When running PHPLoc 2.0.0 on the following code

function fn()
{
    foreach([1,2,3] as $i) {
        echo $i;
    }
}

I get the following metrics

Lines of Code (LOC)                                6
Non-Comment Lines of Code (NCLOC)                  6 (100.00%)
Logical Lines of Code (LLOC)                       1 (16.67%)
  Functions                                        1 (100.00%)
    Average Function Length                        1
  Not in classes or functions                      0 (0.00%)

I get the same when using while instead of foreach.

The problem seems to be in line https://github.com/sebastianbergmann/phploc/blob/master/src/Analyser.php#L306:

if ($token == ';') {
    if ($className !== NULL && !$testClass) {
        $this->count['llocClasses']++;
    }

    else if ($functionName !== NULL) {
        $this->count['llocFunctions']++;
    }

    $this->count['lloc']++;
}

So apparently you are only counting the statements when terminate with a semicolon. But since while and foreach are both executable statements, they should be counted, shouldn't they?

[sebastianbergmann]

Logical Lines of Code (LLOC) are the number of semicolon-terminated statements. This means that for (;;) is counted as two LLOC whereas while and foreach are not counted towards LLOC.