Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Removed bin-dir override in composer.json #34

Merged
merged 1 commit into from

2 participants

@ihabunek

For some reason bin-dir option was changed from the default setting of
vendor/bin to just bin. This caused bin scripts to be installed outside
the vendor subfolder, which is not standard.

@ihabunek ihabunek Removed bin-dir override in composer.json
For some reason bin-dir option was changed from the default setting of
vendor/bin to just bin. This caused bin scripts to be installed outside
the vendor subfolder, which is not standard.
f6373db
@sebastianbergmann sebastianbergmann merged commit a9b9954 into sebastianbergmann:master
@sebastianbergmann

Does the composer/bin/phploc script still find the autoload.php script correctly after this change?

@ihabunek

I was trying to test it just now, but I'm not able to install the latest from master branch. It seems you have an error in your packagist config for phploc.

Look here:
https://packagist.org/packages/phploc/phploc

It says:

Source: https://github.com/sebastianbergmann/phploc/tree/1.7.3

So it points to 1.7.3 branch instead of the master branch. Can you try to change it?

In contrast to this, phpunit is set up correctly:
https://packagist.org/packages/phpunit/phpunit

Source: https://github.com/sebastianbergmann/phpunit/tree/master
@ihabunek

Tried locally. Does not work, but I think i know what the problem is.

  1. You use namespaces, composer.json is not set up properly for namespaces.
  2. In composer/bin/phploc you have the following line:
$textui = new PHPLOC_TextUI_Command;

Well, PHPLOC_TextUI_Command does not exist. It should \SebastianBergmann\PHPLOC\TextUI\Command instead.

Did this ever work? :-)

I will try to get everything in order and submit a patch. Maybe won't have time today, but tomorrow latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 10, 2012
  1. @ihabunek

    Removed bin-dir override in composer.json

    ihabunek authored
    For some reason bin-dir option was changed from the default setting of
    vendor/bin to just bin. This caused bin scripts to be installed outside
    the vendor subfolder, which is not standard.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 4 deletions.
  1. +1 −4 composer.json
View
5 composer.json
@@ -25,8 +25,5 @@
},
"bin": [
"composer/bin/phploc"
- ],
- "config": {
- "bin-dir": "bin"
- }
+ ]
}
Something went wrong with that request. Please try again.