Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

BC break in getMockForAbstractClass #88

Closed
edorian opened this Issue Mar 27, 2012 · 0 comments

Comments

Projects
None yet
1 participant
Collaborator

edorian commented Mar 27, 2012

With b0fe658 I introduced a BC break that breaks SF2

Their tests and helpers are calling

->getMockForAbstractClass($classname, array())

to get "testable abstract classes".

That leads to fatal errors as methods return null instead of their actual return values.

So we'd ether need to revert that or tell people to change it to ($classname, null); Both options are doable as the refactoring work is rather minor but still it would break stuff kinda "unnecessary".

@edorian edorian closed this Jan 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment