Permalink
Browse files

Deprecate BDD functionality.

  • Loading branch information...
sebastianbergmann committed Sep 19, 2010
1 parent 86ac86a commit 6aa9183496f9bb2131d17ba08195a93a07937762
Showing with 22 additions and 12 deletions.
  1. +18 −4 PHPUnit/TextUI/Command.php
  2. +0 −4 Tests/TextUI/help.phpt
  3. +0 −4 Tests/TextUI/help2.phpt
  4. +2 −0 Tests/TextUI/story-isolation.phpt
  5. +2 −0 Tests/TextUI/story.phpt
View
@@ -436,16 +436,34 @@ protected function handleArguments(array $argv)
break;
case '--story': {
+ $this->showMessage(
+ 'The --story functionality is deprecated and ' .
+ 'will be removed in the future.',
+ FALSE
+ );
+
$this->arguments['printer'] = new PHPUnit_Extensions_Story_ResultPrinter_Text;
}
break;
case '--story-html': {
+ $this->showMessage(
+ 'The --story-html functionality is deprecated and ' .
+ 'will be removed in the future.',
+ FALSE
+ );
+
$this->arguments['storyHTMLFile'] = $option[1];
}
break;
case '--story-text': {
+ $this->showMessage(
+ 'The --story-text functionality is deprecated and ' .
+ 'will be removed in the future.',
+ FALSE
+ );
+
$this->arguments['storyTextFile'] = $option[1];
}
break;
@@ -789,9 +807,6 @@ protected function showHelp()
--coverage-html <dir> Generate code coverage report in HTML format.
--coverage-clover <file> Write code coverage data in Clover XML format.
- --story-html <file> Write Story/BDD results in HTML format to file.
- --story-text <file> Write Story/BDD results in Text format to file.
-
--testdox-html <file> Write agile documentation in HTML format to file.
--testdox-text <file> Write agile documentation in Text format to file.
@@ -803,7 +818,6 @@ protected function showHelp()
--loader <loader> TestSuiteLoader implementation to use.
--repeat <times> Runs the test(s) repeatedly.
- --story Report test execution progress in Story/BDD format.
--tap Report test execution progress in TAP format.
--testdox Report test execution progress in TestDox format.
View
@@ -21,9 +21,6 @@ Usage: phpunit [switches] UnitTest [UnitTest.php]
--coverage-html <dir> Generate code coverage report in HTML format.
--coverage-clover <file> Write code coverage data in Clover XML format.
- --story-html <file> Write Story/BDD results in HTML format to file.
- --story-text <file> Write Story/BDD results in Text format to file.
-
--testdox-html <file> Write agile documentation in HTML format to file.
--testdox-text <file> Write agile documentation in Text format to file.
@@ -35,7 +32,6 @@ Usage: phpunit [switches] UnitTest [UnitTest.php]
--loader <loader> TestSuiteLoader implementation to use.
--repeat <times> Runs the test(s) repeatedly.
- --story Report test execution progress in Story/BDD format.
--tap Report test execution progress in TAP format.
--testdox Report test execution progress in TestDox format.
View
@@ -22,9 +22,6 @@ Usage: phpunit [switches] UnitTest [UnitTest.php]
--coverage-html <dir> Generate code coverage report in HTML format.
--coverage-clover <file> Write code coverage data in Clover XML format.
- --story-html <file> Write Story/BDD results in HTML format to file.
- --story-text <file> Write Story/BDD results in Text format to file.
-
--testdox-html <file> Write agile documentation in HTML format to file.
--testdox-text <file> Write agile documentation in Text format to file.
@@ -36,7 +33,6 @@ Usage: phpunit [switches] UnitTest [UnitTest.php]
--loader <loader> TestSuiteLoader implementation to use.
--repeat <times> Runs the test(s) repeatedly.
- --story Report test execution progress in Story/BDD format.
--tap Report test execution progress in TAP format.
--testdox Report test execution progress in TestDox format.
@@ -14,4 +14,6 @@ PHPUnit_TextUI_Command::main();
--EXPECTF--
PHPUnit %s by Sebastian Bergmann.
+The --story functionality is deprecated and will be removed in the future.
+
The story result printer cannot be used in process isolation.
View
@@ -13,6 +13,8 @@ PHPUnit_TextUI_Command::main();
--EXPECTF--
PHPUnit %s by Sebastian Bergmann.
+The --story functionality is deprecated and will be removed in the future.
+
BowlingGameSpec
[x] Score for gutter game is 0

4 comments on commit 6aa9183

@wrobel

This comment has been minimized.

Show comment
Hide comment
@wrobel

wrobel Oct 8, 2010

Contributor

Will there be some kind of replacement for this functionality?

Contributor

wrobel replied Oct 8, 2010

Will there be some kind of replacement for this functionality?

@stloyd

This comment has been minimized.

Show comment
Hide comment
@stloyd

stloyd Oct 8, 2010

I think that Behat (http://github.com/everzet/Behat) could be kinda replacement.

I think that Behat (http://github.com/everzet/Behat) could be kinda replacement.

@wrobel

This comment has been minimized.

Show comment
Hide comment
@wrobel

wrobel Oct 8, 2010

Contributor

@stloyd: Ah, thanks for the hint. I saw that Sebastian forked that yesterday so I guess that is probable then. Will have a look to get an idea of how the migration might look like.

@sebastian: Can you confirm stloyds assumption?

Contributor

wrobel replied Oct 8, 2010

@stloyd: Ah, thanks for the hint. I saw that Sebastian forked that yesterday so I guess that is probable then. Will have a look to get an idea of how the migration might look like.

@sebastian: Can you confirm stloyds assumption?

@sebastianbergmann

This comment has been minimized.

Show comment
Hide comment
@sebastianbergmann

sebastianbergmann Oct 8, 2010

Owner

PHPUnit's BDD functionality is deprecated in PHPUnit 3.5 and will be removed in PHPUnit 3.6. The primary reason for this is that it is unmaintained and does not, for instance, work correctly when used together with other features such as the process isolation. With the availability of Behat, which looks much more powerful, I felt comfortable enough to take this step.

PHPUnit's BDD functionality is deprecated in PHPUnit 3.5 and will be removed in PHPUnit 3.6. The primary reason for this is that it is unmaintained and does not, for instance, work correctly when used together with other features such as the process isolation. With the availability of Behat, which looks much more powerful, I felt comfortable enough to take this step.

Please sign in to comment.