Permalink
Browse files

Fix TRAC-1045.

  • Loading branch information...
1 parent d71967d commit ca1dc2f37a000160c37fa4bf152661877c5ea90c @sebastianbergmann committed Apr 23, 2010
Showing with 6 additions and 1 deletion.
  1. +5 −1 PHPUnit/TextUI/TestRunner.php
  2. +1 −0 README.markdown
@@ -869,7 +869,11 @@ protected function handleConfiguration(array &$arguments)
if ($arguments['filter'] !== FALSE &&
preg_match('/^[a-zA-Z0-9_]/', $arguments['filter'])) {
- $arguments['filter'] = '/' . $arguments['filter'] . '/';
+ // Escape delimiters in regular expression. Do NOT use preg_quote,
+ // to keep magic characters.
+ $arguments['filter'] = '/' . str_replace(
+ '/', '\\/', $arguments['filter']
+ ) . '/';
}
}
}
View
@@ -8,6 +8,7 @@ PHPUnit 3.4.13
* Fixed TRAC-1035: PostgreSQL MetaData queries are incorrect.
* Fixed TRAC-1043: Method names in HTML code coverage report are not properly escaped.
+* Fixed TRAC-1045: `--filter` has problems with umlaut characters.
* The `--repeat` switch is no longer deprecated.
PHPUnit 3.4.12

0 comments on commit ca1dc2f

Please sign in to comment.