Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup PHPUnit\Framework\Constraint\Constraint #3060

Closed
sebastianbergmann opened this issue Apr 3, 2018 · 0 comments
Closed

Cleanup PHPUnit\Framework\Constraint\Constraint #3060

sebastianbergmann opened this issue Apr 3, 2018 · 0 comments
Assignees
@sebastianbergmann
Labels
type/backward-compatibility Something will be/is intentionally broken
Milestone
PHPUnit 8.0

Comments

@sebastianbergmann
Copy link
Owner

  • Remove __construct()
  • Make $exporter private
  • Add protected method exporter() for access to $exporter (and use lazy initialization to create the object)
  • Change public function evaluate($other, $description = '', $returnResult = false) to public function evaluate($other, string $description = '', bool $returnResult = false)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
type/backward-compatibility Something will be/is intentionally broken
Projects
None yet
Milestone
PHPUnit 8.0
Development

No branches or pull requests
1 participant
@sebastianbergmann